-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed some dev-dependencies that broke by updating TypeScript #106
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will the two dev_setup scripts be used later, or why were they added?
They were changed to be executable, in the case of the frontend it's necessary to export an env-variable to allow unsafe ossl for an old version of something. The backend one was already there, and I just made it executable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I don't know why it shows as empty though, I'll take a look at what's the matter with that, because they're supposed to have code |
I'd guess it's a bug, they show as empty as no change was done in the file, only in the rwx-permissions |
Yeah, that's what I reacted at. Lmk once you've figured it out and I'll approve |
They should not be changed from the current ones at all, since it shows no lines removed or added. If you look at the files in the branch they are the same as the ones on main right now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be fine then!
No description provided.