Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some dev-dependencies that broke by updating TypeScript #106

Merged
merged 3 commits into from
May 2, 2024

Conversation

simon-wg
Copy link
Contributor

@simon-wg simon-wg commented May 2, 2024

No description provided.

@simon-wg simon-wg requested a review from ViktorYeet May 2, 2024 17:52
Copy link
Member

@GAsplund GAsplund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the two dev_setup scripts be used later, or why were they added?

@simon-wg
Copy link
Contributor Author

simon-wg commented May 2, 2024

They were changed to be executable, in the case of the frontend it's necessary to export an env-variable to allow unsafe ossl for an old version of something. The backend one was already there, and I just made it executable

Copy link

@ViktorYeet ViktorYeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@simon-wg
Copy link
Contributor Author

simon-wg commented May 2, 2024

I don't know why it shows as empty though, I'll take a look at what's the matter with that, because they're supposed to have code

@simon-wg
Copy link
Contributor Author

simon-wg commented May 2, 2024

I'd guess it's a bug, they show as empty as no change was done in the file, only in the rwx-permissions

@GAsplund
Copy link
Member

GAsplund commented May 2, 2024

Yeah, that's what I reacted at. Lmk once you've figured it out and I'll approve

@simon-wg
Copy link
Contributor Author

simon-wg commented May 2, 2024

They should not be changed from the current ones at all, since it shows no lines removed or added. If you look at the files in the branch they are the same as the ones on main right now.

Copy link
Member

@GAsplund GAsplund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine then!

@simon-wg simon-wg merged commit 5065fd7 into main May 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants