-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/issue 20 #23
Fix/issue 20 #23
Conversation
(The intent is to fix #20, however first the image needs to be able to build lol) |
Co-authored-by: Goostaf <[email protected]>
Now the only issue is to get it to actually work (: the docker image has problems loading the page. |
…e website doesn't work after running the compose file
… integer, also future-proofing for 21XX :P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :)
(Disclaimer, this summary is written by Copilot)
Docker and CI Improvements:
.github/workflows/docker-image.yml
for building and pushing Docker images on themaster
branch.Dockerfile
to remove thestrip-version
stage and upgrade the Rust version used in the build stage from1.53
to1.82
. [1] [2] [3]docker-compose.yml
by renaming the service and removing unnecessary services and volumes.JSON Data Updates:
year
format indata/members.json
from two-digit to four-digit format. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]Rust Code Refactoring:
src/main.rs
to improve code readability by reordering imports, changingyear
type fromu8
tou32
, and reformatting functions. [1] [2] [3] [4] [5]templates/members.html.tera
to correctly display the four-digit year format.Documentation Update:
README.md
to guide users on finding the correct IP address when running the project in Docker.