Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/issue 20 #23

Merged
merged 7 commits into from
Nov 6, 2024
Merged

Fix/issue 20 #23

merged 7 commits into from
Nov 6, 2024

Conversation

simon-wg
Copy link
Contributor

@simon-wg simon-wg commented Nov 6, 2024

(Disclaimer, this summary is written by Copilot)

Docker and CI Improvements:

  • Added a Docker Image CI workflow to .github/workflows/docker-image.yml for building and pushing Docker images on the master branch.
  • Updated the Dockerfile to remove the strip-version stage and upgrade the Rust version used in the build stage from 1.53 to 1.82. [1] [2] [3]
  • Simplified docker-compose.yml by renaming the service and removing unnecessary services and volumes.

JSON Data Updates:

Rust Code Refactoring:

  • Refactored src/main.rs to improve code readability by reordering imports, changing year type from u8 to u32, and reformatting functions. [1] [2] [3] [4] [5]
  • Updated templates/members.html.tera to correctly display the four-digit year format.

Documentation Update:

  • Added a note in README.md to guide users on finding the correct IP address when running the project in Docker.

@simon-wg
Copy link
Contributor Author

simon-wg commented Nov 6, 2024

(The intent is to fix #20, however first the image needs to be able to build lol)

@simon-wg
Copy link
Contributor Author

simon-wg commented Nov 6, 2024

Now the only issue is to get it to actually work (: the docker image has problems loading the page.

@simon-wg simon-wg marked this pull request as ready for review November 6, 2024 18:24
Copy link
Contributor

@ViktorYeet ViktorYeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@GAsplund GAsplund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@simon-wg simon-wg merged commit 9b7d79a into master Nov 6, 2024
1 check passed
@simon-wg simon-wg deleted the fix/issue_20 branch November 6, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants