Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed regex error on save draft #405

Merged
merged 5 commits into from
Jun 19, 2024

Conversation

droberts-ctrlo
Copy link
Contributor

No description provided.

lib/GADS.pm Outdated Show resolved Hide resolved
@abeverley
Copy link
Contributor

Thanks Dave, this is great. Can you just alter the formatting to match the existing code please?

E.g. instead of:

if(!$options{draft}) {

Do:

if (!$options{draft})
{

And $datum->set_value($newv, draft => defined(param draft)) instead of $datum->set_value($newv, draft=>defined(param draft))

@abeverley
Copy link
Contributor

Thanks. Sorry to be pernickety but there are a few others in the remaining code too. Let's take a look at using perltidy!

@abeverley abeverley merged commit 083f2fd into ctrlo:dev Jun 19, 2024
3 of 6 checks passed
@droberts-ctrlo droberts-ctrlo deleted the save-draft-no-regex branch June 21, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants