Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added clear filter button #421

Merged
merged 3 commits into from
Jun 14, 2024
Merged

Conversation

droberts-ctrlo
Copy link
Contributor

As session filter doesn't clear, a clear filter button had to be added. The icon is the best I feel I could do as there isn't one I feel is suitable within our icon set.

As session filter doesn't clear, a clear filter button had to be added. The icon is the best I feel I could do as there isn't one I feel is suitable within our icon set.
@abeverley
Copy link
Contributor

Thanks Dave, this is great, and the use of the icon is quite ingenious! I think you could just simplify the condition in the controller a bit like this:

if (param 'audit_filtering')
{
    ...
}
elsif (defined param('clear'))
{
    session 'audit_filtering' => undef;
}

lib/GADS.pm Outdated Show resolved Hide resolved
@abeverley abeverley merged commit bb7a616 into ctrlo:dev Jun 14, 2024
3 of 6 checks passed
@droberts-ctrlo droberts-ctrlo deleted the AuditFilterFix branch June 18, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants