Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format CHANGELOG #136

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Format CHANGELOG #136

merged 1 commit into from
Aug 19, 2024

Conversation

mpkorstanje
Copy link
Contributor

@mpkorstanje mpkorstanje commented Aug 19, 2024

🤔 What's changed?

The release process uses the CHANGELOG.md to determine the next version. With v7.18.1 this went wrong and became vIn because the version was assumed to be In Git as this was the first version header according to the format.

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)

♻️ Anything particular you want feedback on?

I added the statement about semantic versioning.

@lsuski is that correct for this project.

I also see that you're following the releases in Cucumber JVM. This is nice, but not required. If you have changes of your own you can can increment the version of cucumber-android as required by Semver.

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

The release process uses the CHANGELOG to
determine the next version. With v7.18.1 this went
wrong and became `vIn` because the version was
assumed to be `In Git` as this was the first
version header according to the format.
@lsuski lsuski merged commit 0c08b28 into main Aug 19, 2024
1 check passed
@lsuski lsuski deleted the fix-change-log-header branch August 19, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants