Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parameter highlighting for outline steps with leading spaces #219

Merged
merged 2 commits into from
Jul 14, 2024

Conversation

michaelboyles
Copy link
Contributor

@michaelboyles michaelboyles commented Jun 19, 2024

πŸ€” What's changed?

Fixed a bug where leading spaces would incorrectly offset the highlighting of scenario outline variables

⚑️ What's your motivation?

Fixes #218

🏷️ What kind of change is this?

  • πŸ› Bug fix (non-breaking change which fixes a defect)

πŸ“‹ Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

@kieran-ryan kieran-ryan added the πŸ› bug Defect / Bug label Jul 6, 2024
@kieran-ryan kieran-ryan changed the title fix: invalid syntax highlighting for scenario outline variables fix: parameter highlighting for scenario outline steps with leading spaces Jul 14, 2024
@kieran-ryan kieran-ryan changed the title fix: parameter highlighting for scenario outline steps with leading spaces fix: parameter highlighting for outline steps with leading spaces Jul 14, 2024
Copy link
Member

@kieran-ryan kieran-ryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've made excellent contributions @michaelboyles - very much appreciated. Apologies for the delay in reviewing; just dropped a redeclaration of the line number - solution looks ace, thanks a million!

@kieran-ryan kieran-ryan merged commit 6db4a1a into cucumber:main Jul 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
πŸ› bug Defect / Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Leading spaces breaks syntax highlighting for scenario outline
2 participants