Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not link to ndjson[dot]org in README.md #258

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

youtux
Copy link
Contributor

@youtux youtux commented Oct 25, 2024

The ndjson[dot]org website contains malware. We should not link to it.

See ndjson/ndjson.github.io#24

πŸ€” What's changed?

⚑️ What's your motivation?

🏷️ What kind of change is this?

  • πŸ“– Documentation (improvements without changing code)
  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)
  • πŸ› Bug fix (non-breaking change which fixes a defect)
  • ⚑ New feature (non-breaking change which adds new behaviour)
  • πŸ’₯ Breaking change (incompatible changes to the API)

♻️ Anything particular you want feedback on?

πŸ“‹ Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

The `ndjson[dot]org` website contains malware. We should not link to it.

See ndjson/ndjson.github.io#24
@mpkorstanje
Copy link
Contributor

mpkorstanje commented Oct 27, 2024

Oh lovely.

But looks like we could switch to jsonlines.

ndjson/ndjson-spec#35 (comment)

@mpkorstanje mpkorstanje merged commit 73523c0 into main Oct 27, 2024
26 checks passed
@mpkorstanje mpkorstanje deleted the do-not-link-to-njsondotorg branch October 27, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants