Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(main): add test webhooks #56

Merged
merged 1 commit into from
Oct 19, 2024
Merged

feat(main): add test webhooks #56

merged 1 commit into from
Oct 19, 2024

Conversation

cuisongliu
Copy link
Owner

This pull request introduces a new test case to the api/v1beta1/webhook_suite_test.go file. The test case verifies that the Controller.Replicas field is immutable by attempting to update it and checking for the appropriate error message.

Testing enhancements:

  • api/v1beta1/webhook_suite_test.go: Added a new test case It("Update Controller Replicas", func() { to ensure that the Controller.Replicas field cannot be updated and that the correct error messages are returned.

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 76.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 30.48%. Comparing base (b65beac) to head (d582a29).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
e2e/utils.go 76.66% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
+ Coverage   27.74%   30.48%   +2.74%     
==========================================
  Files           4        4              
  Lines         310      351      +41     
==========================================
+ Hits           86      107      +21     
- Misses        203      224      +21     
+ Partials       21       20       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cuisongliu cuisongliu merged commit 11e5b41 into main Oct 19, 2024
8 checks passed
@cuisongliu cuisongliu deleted the tests branch October 19, 2024 01:05
@github-actions github-actions bot mentioned this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant