Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes various improvements and fixes to the
automq_controller
and related test files to enhance logging, error handling, and test coverage. The most important changes include adding detailed error logs, updating test cases, and modifying the namespace for the tests.Error Handling and Logging Improvements:
internal/controller/automq_controller.go
: Added detailed error logs in multiple functions to provide more context when failures occur. [1] [2] [3] [4] [5]internal/controller/automq_controller_b.go
: Enhanced logging for PVC, service, and deployment creation failures. [1] [2] [3]internal/controller/automq_controller_c.go
: Improved logging for controller PVC, service, and deployment creation failures. [1] [2] [3]Test Case Updates:
e2e/automq_cluster_controller_test.go
: Updated the namespace name and added new test cases for resource creation, reconciliation, and status checks. [1] [2] [3]e2e/automq_cluster_test.go
: Set theNAMESPACE_NAME
environment variable in theBeforeSuite
function.Minor Code Enhancements:
internal/controller/automq_controller.go
: Added index logging in the reconcile loop for better traceability.e2e/automq_cluster_controller_test.go
: Added necessary imports for new test cases.internal/controller/automq_apis.go
: Added a blank line for better code readability..github/workflows/test.yml
: Added a command to get services in all namespaces to the testing workflow.