-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Organize things and rename the package to Rinf #187
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in some cases the product dir can be cleaned independently on temp dir, which would leave symlinks pointing nowhere, which causes xcode to skip the build completely.
Quietly `cargo run` on `build_tool`
Otherwise the check may fail with false positive when there is unfinished NDK installation.
Pub issue: dart-lang/pub#4010 This has been merged but will likely take a while until it trickles down to Flutter stable so in the meanwhile the workaround will resolve the symlink before feeding it to pub. Fixes irondash/cargokit#14
Otherwise CC tries to detect compiler in some cases and may fail during android build.
Otherwise build from Xcode fails. Fixes irondash/cargokit#28
The path to flutter_export_environment.sh is different for iOS project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
It's just as the title says. Rust-In-Flutter is too long for a framework name. The name Rinf doesn't conflict with any existing crates or Flutter package.
Before Committing
Please make sure that you've formatted the files.