Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Organize internal code #357

Merged
merged 32 commits into from
Jun 8, 2024
Merged

Organize internal code #357

merged 32 commits into from
Jun 8, 2024

Conversation

temeddix
Copy link
Member

@temeddix temeddix commented Jun 7, 2024 •
edited
Loading

Changes

This PR is about cleaner code, better maintenance, and being more future-proof

Before Committing

Please make sure that you've analyzed and formatted the files.

dart analyze flutter_ffi_plugin --fatal-infos
dart format .
cargo fmt
cargo clippy --fix --allow-dirty

@temeddix
Remove RefCell from generated code
0b22a48
@temeddix
Rename variables
443eba8
@temeddix
Remove SharedLock type alias
19be2d4
@temeddix
Initial working status of shutdown future
972b442
@temeddix
Use channels with buffers when dealing with lifecycles
b9308a7
@temeddix
Organize code
895fa17
@temeddix
Make dart_shutdown function accessible
43437f5
@temeddix
Make the linter happy
a0ce015
@temeddix
Make dart_shutdown work as expected on the web
81381fe
@temeddix
Change debug code
5e76316
@temeddix
New struct RuntimeDropper
13273ec
@temeddix
Terminate tokio runtime after the main function
02ecbed
@temeddix
Don't send Rust signal when Dart isolate is not initialized
550557d
@temeddix
Update example and template code
2a15666
@temeddix
Reduce the usage of OnceLock
7cd333b
@temeddix
Remove stopRustLogic
9bf6a7a
@temeddix
Do not use OnceLock with generated channels
e6c9b97
@temeddix
Fix message generation
4df0b40
@temeddix
Reduce write_interface macro code
5fa785f
@temeddix
Add a debug message
a28b35f
@temeddix
Clarify a comment
7cb2ad2
@temeddix temeddix changed the title Make awaiting widget disposal from Rust main mandatory Organize internal code Jun 8, 2024
@temeddix temeddix merged commit b1ee067 into main Jun 8, 2024
22 checks passed
@temeddix temeddix deleted the dart-shutdown-await branch June 8, 2024 07:55
@temeddix temeddix mentioned this pull request Jun 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@temeddix