Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purely_cargokit #99

Closed
wants to merge 15 commits into from
Closed

Purely_cargokit #99

wants to merge 15 commits into from

Conversation

bookshiyi
Copy link
Contributor

@bookshiyi bookshiyi commented Aug 17, 2023

Issue #95

  • cargokit as submodule and delete corrosion
  • Example
    • Android target
    • iOS target
    • macOS target
    • Linux target
    • Windows target
  • In project
    • Android target
    • iOS target
    • macOS target
    • Linux target
    • Windows target

@bookshiyi bookshiyi changed the title Purely_cargokit Purely_cargokit #95 Aug 17, 2023
@bookshiyi bookshiyi changed the title Purely_cargokit #95 Purely_cargokit Aug 17, 2023
@temeddix
Copy link
Member

Whoa, this speed was amazing :D I will merge this as soon as all the tests have passed.

@bookshiyi
Copy link
Contributor Author

Whoa, this speed was amazing :D I will merge this as soon as all the tests have passed.

This PR is draft now, I will continue to submit the code and update the progress at here.

Until all targets (Android, iOS, macOS, Linux, Windows) can be compiled, without relying on corrosion and only pure cagokit submodules(without any changes).

@temeddix
Copy link
Member

temeddix commented Aug 17, 2023

I see :) If we are going to use git submodules, we might need to make PRs at cargokit repository too I think, because of some limitations currently in cargokit(such as only being able to use 'relative path', not 'absolute path' for Android).

@bookshiyi
Copy link
Contributor Author

BTW, before developing the CI, I didn't know its magic.
Until the last two days when I adapted to cargokit, it helped me a lot, especially parallel compilation, so convenient.

@temeddix
Copy link
Member

Yeah, this feature looked promising from the start and now it's really helping this project to be more stable. It's such a nice addition to have 😊

@bookshiyi
Copy link
Contributor Author

Yeah, this feature looked promising from the start and now it's really helping this project to be more stable. It's such a nice addition to have 😊

It is happy things that developing CI function with you, and like now.

@temeddix
Copy link
Member

temeddix commented Aug 17, 2023

Please merge new commits from branch main, some CIs are now changed :)

@bookshiyi
Copy link
Contributor Author

Please merge new commits from branch main, some CIs are now changed :)

OK, I will merge it as soon as possible.

@bookshiyi bookshiyi marked this pull request as ready for review August 17, 2023 10:23
@bookshiyi bookshiyi marked this pull request as draft August 17, 2023 10:49
@temeddix
Copy link
Member

temeddix commented Aug 17, 2023

Maybe you can update CI files here directly if needed :| though it is best to avoid to do so

@bookshiyi
Copy link
Contributor Author

Maybe you can update CI files here directly if needed :| though it is best to avoid to do

I will avoid to change CI at this branches.
I just don't have a Windows development environment.😂

README.md Show resolved Hide resolved
@bookshiyi bookshiyi closed this Aug 24, 2023
@bookshiyi bookshiyi deleted the purely_cargokit branch August 24, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants