Fixes some deprecation warnings, and allows import of CSV's with blan…

…k lines (#124)

* Deprecation &  helper update

* conditionally load coveralls
* fix deprecation warnings for riiif & sqlite

* Updates to allow the csv parser to ignore blank lines

Co-authored-by: McClain Looney <[email protected]>

lib/zizia/parsers/csv_parser.rb

@@ -36,7 +36,7 @@ def records
       file.rewind
 
       CSV.parse(file.read, headers: true).each do |row|
-        yield InputRecord.from(metadata: row)
+        yield InputRecord.from(metadata: row) if row.detect { |x| !x.last.nil? }
       end
     rescue CSV::MalformedCSVError => e
       Rails.logger.error "[zizia] The file #{file} could not be parsed as CSV: #{e}"

spec/dummy/config/environment.rb

@@ -2,4 +2,6 @@
 require_relative 'application'
 
 # Initialize the Rails application.
+Rails.application.config.active_record.sqlite3.represent_boolean_as_integer = true
 Rails.application.initialize!
+

spec/dummy/config/initializers/riiif.rb

@@ -1,4 +1,4 @@
-Riiif::Image.file_resolver = Riiif::HTTPFileResolver.new
+Riiif::Image.file_resolver = Riiif::HttpFileResolver.new
 Riiif::Image.info_service = lambda do |id, _file|
   # id will look like a path to a pcdm:file
   # (e.g. rv042t299%2Ffiles%2F6d71677a-4f80-42f1-ae58-ed1063fd79c7)

spec/spec_helper.rb

@@ -1,6 +1,8 @@
 # frozen_string_literal: true
-require 'coveralls'
-Coveralls.wear!('rails')
+unless ENV['NOCOV']
+  require 'coveralls'
+  Coveralls.wear!('rails')
+end
 require 'pry' unless ENV['CI']
 
 ENV['environment'] ||= 'test'

spec/views/zizia/importer_documentation/guide.html.erb_spec.rb

@@ -1,9 +1,10 @@
 # frozen_string_literal: true
 require 'spec_helper'
+require 'rails_helper'
 
 RSpec.describe "zizia/importer_documentation/guide.html.erb", type: :view do
   before do
-    view.stub(:render_guide).and_return('<h1 id="title">Title</h1>')
+    allow(view).to receive(:render_guide).and_return('<h1 id="title">Title</h1>')
   end
 
   it 'renders as html' do

spec/zizia/csv_parser_spec.rb

@@ -13,6 +13,7 @@
       <<-EOS
 title,description,date created
 The Moomins and the Great Flood,"The Moomins and the Great Flood (Swedish: Småtrollen och den stora översvämningen, literally The Little Trolls and the Great Flood) is a book written by Finnish author Tove Jansson in 1945, during the end of World War II. It was the first book to star the Moomins, but is often seen as a prelude to the main Moomin books, as most of the main characters are introduced in the next book.",1945
+
 Comet in Moominland,"Comet in Moominland is the second in Tove Jansson's series of Moomin books. Published in 1946, it marks the first appearance of several main characters, like Snufkin and the Snork Maiden.",1946
 EOS
     end