Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use app.notify action #2689

Closed
wants to merge 2 commits into from
Closed

Use app.notify action #2689

wants to merge 2 commits into from

Conversation

AndreasArvidsson
Copy link
Member

The fewer module imports from Talon the better

Checklist

  • [/] I have added tests
  • [/] I have updated the docs and cheatsheet
  • [/] I have not broken the cheatsheet

@AndreasArvidsson AndreasArvidsson requested a review from a team as a code owner November 21, 2024 09:58
Copy link
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I agree with this one, but if you feel strongly I'm not opposed. It makes our code longer and in at least two files it doesn't remove any imports

@AndreasArvidsson
Copy link
Member Author

We had this discussion in community and all agreed that we should use a Talon action if it exists. Importing modules to get access to features that Talon already exposes as an action is bad code. For example the user might have redefined notified to send its someplace else and we should respect that. But it's not really something I care to much about when it comes to notify in particular. I think in the two files where we actually get rid of an import I think it's an improvement at least.

@pokey
Copy link
Member

pokey commented Dec 12, 2024

update from meet-up: we didn't like the following

  • no type hints
  • can't use body kwarg so would have to switch back for cases where you need it

@pokey pokey closed this Dec 12, 2024
@pokey pokey deleted the appNotify branch December 12, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants