Check for community installation #2692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pokey
reviewed
Nov 30, 2024
| if errors: | ||
| errors.insert(0, "https://github.com/talonhub/community") | ||
| message = "\n".join(errors) | ||
| app.notify("Cursorless missing community repository", body=message) |
There was a problem hiding this comment.
I don't think we want the errors to be in the app notification; I'd put them in a print so they go in the log. Most people will just be missing community so they won't care which captures they're missing
Also, is it possible to make it so that if they click the notification it goes to community
There was a problem hiding this comment.
I have updated the message now.
I don't think there is any click events on the app notification.
pokey
reviewed
Dec 12, 2024
pokey
approved these changes
Dec 12, 2024
cursorless-bot
pushed a commit
that referenced
this pull request
Dec 12, 2024
Related ##1953 ## Checklist - [/] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [/] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [/] I have not broken the cheatsheet --------- Co-authored-by: Pokey Rule <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #1953
Checklist