Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate tag user.cursorless_custom_number_small #2699

Merged
merged 5 commits into from
Dec 21, 2024

Conversation

AndreasArvidsson
Copy link
Member

@AndreasArvidsson AndreasArvidsson commented Dec 21, 2024

Community has had a good version of number_small for two years now.

Talon grammar tests passed

Checklist

  • / ] I have added tests
  • [/] I have updated the docs and cheatsheet
  • [/] I have not broken the cheatsheet

@AndreasArvidsson AndreasArvidsson requested a review from a team as a code owner December 21, 2024 03:36
Copy link
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment otherwise good stuff!

cursorless-talon/src/number_small.py Outdated Show resolved Hide resolved
@AndreasArvidsson AndreasArvidsson added this pull request to the merge queue Dec 21, 2024
Merged via the queue into main with commit 8574fc7 Dec 21, 2024
15 checks passed
@AndreasArvidsson AndreasArvidsson deleted the deprecateNumberTag branch December 21, 2024 18:31
cursorless-bot pushed a commit that referenced this pull request Dec 21, 2024
Community has had a good version of number_small for two years now.

Talon grammar tests passed

## Checklist

- / ] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [/] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [/] I have not broken the cheatsheet

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Co-authored-by: Pokey Rule <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants