New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for event deduplication #98

Open

joandvgv wants to merge 1 commit into customerio:main from joandvgv:main

+3 −2

joandvgv commented Jun 29, 2023

Hi all! I noticed the current track event is not sending the id as part of the payload so the event deduplication feature is not working.

This should do the fix, am I right?

Can update formatting or attend any request from repository owners if this PR makes sense.

Thank you!


          Update track.py

b03845e

newhook commented Jul 3, 2023

Hey Joan , thanks for the PR. However, won't this break existing code which passes "id" as part of the data payload? For example, consider:

cio = CustomerIO(site_id, api_key, region=Regions.US)
cio.track(customer_id="5", name='purchased', id='item_47', price=2.25)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet