Update dependency rubocop to v1 #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mend-5034428[bot]](https://avatars.githubusercontent.com/u/5034428?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
'~> 0.33'->'~> 1.67'Release Notes
rubocop/rubocop (rubocop)
v1.67.0Compare Source
New features
Lint/DuplicateSetElementcop. ([@koic][])AllowRBSInlineAnnotationconfig option toLayout/LeadingCommentSpaceto support RBS::Inline style annotation comments. ([@tk0miya][])rubocop -V. ([@koic][])Bug fixes
Style/Semicolonwhen using a semicolon between a closing parenthesis after a line break and a consequent expression. ([@koic][])Lint/ParenthesesAsGroupedExpressionwith compound ranges. ([@gsamokovarov][])Style/BlockDelimiterswhen a single line do-end block with an inlinerescuewith a semicolon beforerescue. ([@koic][])Layout/AccessModifierIndentationwhen the access modifier is on the same line as the class definition. ([@koic][])Style/OneLineConditionalwhen using nested if/then/else/end. ([@koic][])Lint/ImplicitStringConcatenationwithLint/TripleQuoteswhen string literals with triple quotes are used. ([@koic][])Style/ArgumentsForwardingwhen using only forwarded arguments in brackets. ([@koic][])Style/CombinableLoopswhen looping over the same data with different block variable names. ([@koic][])Style/RescueModifierwhen using modifier rescue for method call with heredoc argument. ([@koic][])--auto-gen-configwhen passing an absolute config path. ([@earlopain][])Style/OperatorMethodCallwith/operations followed by a parenthesized argument. ([@dvandersluis][])Style/IfUnlessModifierwhen multilineifthat fits on one line and using implicit method call with hash value omission syntax. ([@koic][])Style/ArgumentsForwardingwith Ruby 3.0 and optional position arguments. ([@earlopain][])Lint/AmbiguousRangewhen using rational literals. ([@koic][])Lint/RedundantSafeNavigationwith namespaced constants. ([@earlopain][])Style/OperatorMethodCallwith named forwarding. ([@earlopain][])Style/AccessModifierDeclarationswhenAllowModifiersOnAttrs: trueand using splat with a percent symbol array, or with a constant. ([@koic][])Style/RedundantLineContinuationwhen line continuations with comparison operator and the LHS is wrapped in parentheses. ([@koic][])Style/ArgumentsForwardingwhen argument is used inside a block. ([@dvandersluis][])Style/CollectionCompactwhen usingdelete_if. ([@masato-bkn][])regexpinLint/LiteralInInterpolation. ([@dvandersluis][])Style/IfWithSemicolonwhen single-lineif/;/endwhen the then body contains a method call with[]or[]=. ([@koic][])Style/HashEachMethodsif the hash is modified within the block. ([@dvandersluis][])TargetRubyVersionfrom a gemspec when the gemspec is not named like the folder it is located in. ([@earlopain][])Style/GuardClausewhen using heredoc withoutelsebranch. ([@earlopain][])Lint/BigDecimalNewwhen using::BigDecimal.new. ([@earlopain][])Style/MethodCallWithArgsParentheseswithEnforcedStyle: omit_parenthesesand whitespace. ([@earlopain][])Style/RedundantBeginandStyle/BlockDelimiterswithEnforcedStyle: braces_for_chaining. ([@earlopain][])Changes
Style/AccessorGrouping. ([@tk0miya][])AllowedMethodsconfiguration toLayout/FirstMethodArgumentLineBreak. ([@dvandersluis][])Style/ArgumentsForwardingfor detecting forwarding of all anonymous arguments. ([@dvandersluis][])Style/CommentedKeyword. ([@tk0miya][])RuboCop::Cop::Cop. ([@earlopain][])EnforcedShorthandSyntax: eitherby default forStyle/HashSyntax. ([@koic][])Naming/InclusiveLanguagewhen a sole suggestion is set. ([@koic][])Style/SelectByRegexpaware offilterin Ruby version 2.6 or above. ([@masato-bkn][])Lint/SafeNavigationConsistencycop to check that the safe navigation operator is applied consistently and without excess or deficiency. ([@koic][])Style/SafeNavigationoffenses. ([@dvandersluis][])filter/filter!inStyle/CollectionCompact. ([@masato-bkn][])Lint/UriRegexpto avoid obsolete API. ([@koic][])Style/MapIntoArrayto be able to handle arrays created using[].tap. ([@dvandersluis][])Style/ReturnNilInPredicateMethodDefinitionto detect implicitnilreturns insideif. ([@dvandersluis][])v1.66.1Compare Source
Bug fixes
Style/IfWithSemicolonwhen using nested single-line if/;/end in block of if/else branches. ([@koic][])Style/EmptyLiteralwithHash.new([]). ([@earlopain][])Style/EmptyElsewhenAllowComments: trueand the else clause is missing. ([@vlad-pisanov][])Style/MapIntoArrayautocorrection when usingensure,def,defsandfor. ([@vlad-pisanov][])v1.66.0Compare Source
New features
StringLiteralsFrozenByDefaultoption for correct analysis withRUBYOPT=--enable=frozen-string-literal. ([@earlopain][])DocumentationExtensionglobal option to serve documentation with extensions different than.html. ([@earlopain][])Lint/UselessNumericOperationcop to check for inconsequential numeric operations. ([@zopolis4][])Style/RedundantInterpolationUnfreezecop to check fordupand@+on interpolated strings in Ruby >= 3.0. ([@earlopain][])Bug fixes
Lint/ImplicitStringConcatenationwhen implicitly concatenating a string literal with a line break and string interpolation. ([@koic][])Style/IdenticalConditionalBrancheswhen handling empty case branches. ([@koic][])Style/IfWithSemicolonwhen a nestedifwith a semicolon is used. ([@koic][])Style/InPatternThenwhen using alternative pattern matching deeply. ([@koic][])Style/OneLineConditionalwhen using if/then/else/end with multiple expressions in thethenbody. ([@koic][])Layout/EmptyLineBetweenDefswhen two method definitions are on the same line separated by a semicolon. ([@koic][])Style/IfWithSemicolonwhen a single-lineif/;/endhas an argument in the then body expression. ([@koic][])Style/IfWithSemicolonwhen using multiple expressions in theelsebody. ([@koic][])Style/TrailingBodyOnMethodDefinitionwhen an expression precedes a method definition on the same line with a semicolon. ([@koic][])Layout/BlockAlignmentwhenEnforcedStyleAlignWith: either (default). ([@koic][])Style/MultipleComparisonwhen expression with more comparisons precedes an expression with less comparisons. ([@fatkodima][])Layout/EmptyLinesAroundExceptionHandlingKeywordswhenensureorelseandendare on the same line. ([@koic][])Lint/ImplicitStringConcatenationwhen there are multiple adjacent string interpolation literals on the same line. ([@koic][])Style/GuardClausewhen if clause is empty and correction would not fit on single line because ofLayout/LineLength. ([@earlopain][])Style/ParallelAssignmentwhen using__FILE__. ([@earlopain][])TargetRubyVersiondetection if the gemspec is not valid syntax. ([@earlopain][])Lint/Voidwhen usingensure,defsandnumblock. ([@vlad-pisanov][])Style/MapIntoArraywhen initializing the destination usingArray[],Array([]), orArray.new([]). ([@vlad-pisanov][])Style/EmptyLiteralwhen usingArray[],Hash[],Array.new([])andHash.new([]). ([@vlad-pisanov][])Style/Aliaswhen using multiplealiasindef. ([@koic][])Style/EmptyElsewhen a comment-onlyelseis used afterelsifandAllowComments: trueis set. ([@koic][])Style/MapIntoArraywhen splatting. ([@earlopain][])Style/ArgumentsForwardingwhen forwarding kwargs/block arg with non-matching additional args. ([@koic][])Style/RedundantConditionwhen using modifieriforunless. ([@koic][])Lint/Voidwhen using using frozen literals. ([@vlad-pisanov][])Lint/EmptyConditionalBodywhen missingelsifbody withendon the same line. ([@koic][])Lockfileparser when it contains incompatibleBUNDLED WITHversions. ([@earlopain][])TargetRubyVersionthrough the gemfile if the gemfile ruby version is below 2.7. ([@earlopain][])Changes
get_!,set_!,get_?,set_?,get_=, andset_=inNaming/AccessorMethodName. ([@koic][])Lint/UselessAssignmentautocorrection safe. ([@koic][])Style/RedundantRegexpArgumentrespect theEnforcedStyleofStyle/StringLiterals. ([@koic][])rexmlgem. ([@bquorning][])RuboCop::AST::RationalNode. ([@koic][])v1.65.1Compare Source
New features
Naming/PredicateNameto check that allForbiddenPrefixesare being checked. ([@maxjacobson][])Bug fixes
Lint/FloatComparisonwhen comparing with rational literal. ([@koic][])Lint/UselessAssignmentwhen same name variables are assigned using chained assignment. ([@koic][])Style/InvertibleUnlessConditionwhen using empty parenthesis as condition. ([@earlopain][])fileutilsbefore calculatingbefore_us. ([@r7kamura][])Lint/ImplicitStringConcatenationwhen using adjacent string interpolation literals on the same line. ([@koic][])Style/GlobalStdStreamwhen using namespaced constants likeFoo::STDOUT. ([@earlopain][])Style/ZeroLengthPredicatewhen using safe navigation and non-zero comparison. ([@fatkodima][])Lint/UselessAssignmentwhen pattern match variable is assigned and used in a block. ([@koic][])Naming/RescuedExceptionsVariableNamewhen using hash value omission. ([@koic][])v1.65.0Compare Source
New features
Gemspec/AddRuntimeDependencycop. ([@koic][])Bug fixes
Style/ArgumentsForwardingwhen arguments forwarding inyield. ([@koic][])Layout/SpaceAroundOperatorswhen using multiple spaces between an operator and a tailing comment. ([@koic][])Lint/ToEnumArgumentswhen enumerator is created for another method. ([@koic][])Style/MethodCallWithArgsParentheseswhenEnforcedStyle: omit_parenthesesis set and parenthesized method call is used before constant resolution. ([@koic][])Style/RedundantBeginwhen endless method definition withrescue. ([@koic][])Style/RedundantRegexpCharacterClasswhen using regexp_parser gem 2.3.1 or older. ([@koic][])Style/SuperArgumentswhen the hash argument is or-assigned. ([@koic][])Style/SymbolProcwhen using lambda->with one argument and multilinedo...endblock. ([@koic][])inherit_gemconfig when the Gemfile contains an uninstalled git gem. ([@earlopain][])inherit_gemconfig when running RuboCop without bundler and no Gemfile exists. ([@earlopain][])Lint/UnmodifiedReduceAccumulatorwhen the block is empty. ([@earlopain][])Lint/Voidwhen void expression with guard clause is not on last line. ([@koic][])Lint/Voidwhen using parenthesized void operators. ([@koic][])Style/ZeroLengthPredicatewhen using safe navigation operator. ([@koic][])Lint/NestedMethodDefinitionwhen definition of method on variable. ([@koic][])Style/HashExceptwhen usingrejectand callinginclude?method with bang. ([@koic][])Style/SendWithLiteralMethodNameusingsendwith writer method name. ([@koic][])Style/SuperArgumentswhen calling super in a block. ([@koic][])Changes
CountModifierFormsoption toMetrics/BlockNestingand set it tofalseby default. ([@koic][])bundle update. ([@koic][])Style/MapCompactWithConditionalBlockaware offilter_map. ([@koic][])Lint/ImplicitStringConcatenation. ([@koic][])v1.64.1Compare Source
Bug fixes
Style/CopyrightwhenAutocorrectNoticeis missing. ([@koic][])Style/SuperArgumentswhen the methods block argument is reassigned beforesuper. ([@earlopain][])Style/RedundantLineContinuationwhen line continuations involvebreak,next, oryieldwith a return value. ([@koic][])Style/SendWithLiteralMethodNamewhenpublic_sendargument is a method name that cannot be autocorrected. ([@koic][])v1.64.0Compare Source
New features
either_consistentSupportedShorthandSyntaxtoStyle/HashSyntax. ([@pawelma][])Style/SendWithLiteralMethodNamecop. ([@koic][])Style/SuperArgumentscop. ([@earlopain][])--formatcommand line option. ([@koic][])AllowModifiersOnAttrsoption forStyle/AccessModifierDeclarations. ([@krororo][])AllowedMethodsforStyle/DocumentationMethod. ([@koic][])Bug fixes
Style/Copyrightwhen using multiline copyright notice. ([@koic][])Layout/EmptyCommentwhen using an empty comment next to code after comment line. ([@koic][])Style/ArgumentsForwardingwhen forward target issuper. ([@koic][])Style/ArgumentsForwardingwhen forward target is safe navigation method. ([@koic][])Style/MapIntoArraywhen usingeachwithout receiver with<<to build an array. ([@koic][])--no-exclude-limitgenerating a todo withMaxconfig instead of listing everything out withExclude. ([@earlopain][])TargetRailsVersionwhen parsing from the lockfile with prerelease rails. ([@earlopain][])Changes
cop.documentation_urlwith--show-docs-urlwhen passing a config as argument. ([@earlopain][])ActiveSupportExtensionsEnabledforStyle/SymbolProc. ([@koic][])workspace/executeCommandLSP method. ([@koic][])v1.63.5Compare Source
Bug fixes
Layout/FirstArgumentIndentationwhen specifyingEnforcedStyle: with_fixed_indentationofLayout/ArrayAlignment. ([@koic][])Metrics/BlockLengthwhen theCountAsOneconfig is invalid. ([@koic][])Style/NumericPredicateis used with negations. ([@fatkodima][])Layout/CommentIndentationfor comment-only pattern matching. ([@nekketsuuu][])v1.63.4Compare Source
Bug fixes
rubocop -Vwhen.rubocop.ymlcontains ERB. ([@earlopain][])Style/RedundantLineContinuationwhen line continuations involvereturnwith a return value. ([@koic][])textDocument/diagnostic. ([@muxcmux][])bundle exec. ([@amomchilov][])v1.63.3Compare Source
Bug fixes
Lint/UnreachableCodewhen using pattern matching. ([@koic][])Lint/EmptyFilein formatters when using cache. ([@earlopain][])RuboCop::Lockfilewhen the constant Bundler is uninitialized. ([@koic][])Changes
v1.63.2Compare Source
Bug fixes
Lint/MixedCaseRangewhen a character betweenZandais used in the regexp range. ([@koic][])RuboCop::Lockfilewhen there is no Bundler environment. ([@koic][])Style/ArgumentsForwardingwhen using block arg in nested method definitions. ([@koic][])Lint/UnreachableLoopwhen using pattern matching. ([@koic][])Changes
debug/open_nonstopfromLint/Debuggerby default. ([@koic][])v1.63.1Compare Source
Bug fixes
Lint/AssignmentInConditionif assigning inside a method call. ([@earlopain][])RuboCop::Lockfile::Bundler", caused when running RuboCop withoutbundler execon codebases that userubocop-rails. ([@amomchilov][])v1.63.0Compare Source
New features
Style/MapIntoArraycop. ([@ymap][])requires_gemAPI for declaring which gems a Cop needs. ([@amomchilov][])Bug fixes
Lint/RedundantWithIndexwhen callingwith_indexwith receiver and a block. ([@koic][])Style/AliaswithEnforcedStyle: prefer_aliaswhen callingalias_methodwith fewer than 2 arguments. ([@earlopain][])Style/ExactRegexpMatchwhen callingmatchwithout a receiver. ([@earlopain][])Style/RedundantEachwhen usingreverse_each.eachwithout a block. ([@earlopain][])&.the same way as.for setter methods inLint/AssignmentInCondition. ([@jonas054][])Style/RedundantLineContinuationwhen using line continuation with modifier. ([@koic][])Naming/BlockForwardingwhen using explicit block forwarding in block method and others. ([@koic][])Style/EvalWithLocationwhen usingevalwith a line number from a method call or a variable. ([@koic][])Style/RedundantArgumentwhen when single-quoted strings for cntrl character. ([@koic][])Style/RedundantLineContinuationwhen using line continuations with&&or||operator in assignment. ([@koic][])Style/RedundantLineContinuationwhen multi-line continuations with operators. ([@koic][])Style/CollectionCompactwhen usingdelete_if. ([@koic][])Style/RedundantPercentQsafe on multiline strings. ([@boardfish][])Naming/FileNameandNaming/InclusiveLanguagefor empty files. ([@earlopain][])Style/Copyrightwhen the file is empty. ([@earlopain][])Changes
Lint/Debugger. ([@ydah][])Rakefile.rbinNaming/FileNamein the default config. ([@artur-intech][])Lint/Debuggeraware ofruby/debugrequires. ([@earlopain][])rubocop -Vdisplay rubocop-rspec_rails version when using it. ([@ydah][])Bundler::LockfileParser. ([@amomchilov][])v1.62.1Compare Source
Bug fixes
Style/HashEachMethodswhen the key block argument ofEnumerable#eachmethod is unused afterchunk. ([@koic][])Style/NilComparisonwithout receiver andEnforcedStyle: comparison. ([@earlopain][])Gemspec/RequiredRubyVersionwhen the file is empty. ([@earlopain][])Lint/RedundantWithIndexwhen the method has no receiver. ([@earlopain][])Lint/UselessTimeswhen no block is present. ([@earlopain][])Style/ClassVarswhen callingclass_variable_setwithout arguments. ([@earlopain][])Style/ForwithEnforcedStyle: forwhen no receiver. ([@earlopain][])Layout/MultilineMethodCallIndentationwith safe navigation and assignment method. ([@earlopain][])Lint/MixedCaseRangewith invalid byte sequence in UTF-8. ([@earlopain][])RedundantCurrentDirectoryInPathin case ofrequire_relativewithout arguments. ([@viralpraxis][])Layout/EmptyLineAfterMagicCommentwhen the file is comments only. ([@earlopain][])Layout/RedundantLineBreakwhen using&&or||after a backslash newline. ([@koic][])Style/MultilineMethodSignaturewhen there is a newline directly after the def keyword. ([@earlopain][])Style/RaiseArgswithEnforcedStyle: compactwhen passing more than 2 arguments toraise. ([@earlopain][])Lint/Syntaxgetting disabled byrubocop:disable Lint/Syntax. ([@earlopain][])Changes
LineLengthphase on--auto-gen-only-exclude. ([@sambostock][])v1.62.0Compare Source
New features
TargetRubyVersion 3.4(experimental). ([@koic][])Bug fixes
Lint/ToEnumArgumentswhen enumerator is created for another method in no arguments method definition. ([@koic][])Style/RedundantLineContinuationwhen using line concatenation and calling a method with keyword arguments without parentheses. ([@koic][])Style/Encodingwhen magic encoding with mixed case present. ([@koic][])required_ruby_versionis read from another file. ([@davidrunger][])Layout/SpaceInsideHashLiteralBraces. ([@bquorning][])v1.61.0Compare Source
New features
--editor-modeCLI option. ([@koic][])AutoCorrect: contextualoption for LSP. ([@koic][])OffenseCountFormatterdisplay autocorrection information. ([@koic][])RuboCop::LSP.enableAPI to enable LSP mode. ([@koic][]).rubocop.ymlandrubocop/config.ymlin compliance with dot-config. ([@koic][])Bug fixes
Style/ArgumentsForwardingwhen using block arg forwarding to within block with Ruby 3.3.0. ([@koic][])Gemspec/RequiredRubyVersionwhenrequired_ruby_versionis specified withGem::Requirement.newand is higher thanTargetRubyVersion. ([@koic][])Style/CaseLikeIfwhen using==with literal and using ternary operator. ([@koic][])Lint/EmptyConditionalBodywhen missingifbody with conditionalelsebody. ([@koic][])Style/MapCompactWithConditionalBlockwhen using guard clause withnextimplicitly nil. ([@koic][])Style/ObjectThenwhen usingyield_selfwithout receiver. ([@koic][])--auto-gen-configbug forLayout/SpaceBeforeBlockBraces. ([@jonas054][])Style/CommentedKeyword. ([@jonas054][])Includefrom inherited file in a parent directory. ([@jonas054][])Layout/RedundantLineBreakwhen using index access call chained on multiline hash literal. ([@koic][])Style/MultilineTernaryOperatorwhen nesting multiline ternary operators. ([@koic][])Style/RedundantAssignmentwhen using pattern matching. ([@koic][])Style/RedundantReturnwhen using pattern matching. ([@koic][])Lint/RedundantSafeNavigationwhen using safe navigation operator for literal receiver. ([@koic][])Style/ArgumentsForwardingwhen using forwardable block arguments with Ruby 3.2+. ([@koic][])Lint/Voidwheneachblock with conditional expressions that has multiple statements. ([@koic][])Style/InverseMethodswhen using relational comparison operator with safe navigation. ([@koic][])Style/InvertibleUnlessCondition. ([@sambostock][])omit_parenthesesStyle/MethodCallWithArgsParentheses. ([@gsamokovarov][])Changes
Style/RaiseArgsas unsafe. ([@r7kamura][])v1.60.2Compare Source
Bug fixes
Layout/RedundantLineBreakwhen using index access call chained on multiple lines with backslash. ([@koic][])Style/ArgumentsForwardingwhen naming a block argument&. ([@koic][])Style/HashEachMethodswhen both arguments are unused. ([@earlopain][])Style/HashEachMethodswhen a block with both parameters has no body. ([@earlopain][])Errno::ENOENTerror when using server mode. ([@koic][])Style/ArgumentsForwardingwhen using block arg forwarding wiConfiguration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.