factor out code to determine DNS address record label #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a second location in management/ip.html where we need to set the label for the DNS address record. This second location in the code get executed when a new address is created (and there is no "id" passed in via the arguments of the Mason component.) The need for a second place to contain logic warrants factoring out the logic to determine the (DNS address record) label for a given IP block object into the class. Add new subroutine to Netdot::Model::Ipblock, dns_address_record_label that returns 'A' or 'AAAA' depending on the version of the object. Also add in some unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Carlos,
The branch you merged earlier today to set the correct DNS address record label was slightly incomplete. When one creates a new address (either v4 or v6) the label for the DNS address record still used 'A/AAAA' when it could have been smarter and chosen the right label. This branch fixes those omissions.
Thanks!
-m
There is a second location in management/ip.html where we need to set
the label for the DNS address record. This second location in the code
get executed when a new address is created (and there is no "id" passed
in via the arguments of the Mason component.)
The need for a second place to contain logic warrants factoring out the
logic to determine the (DNS address record) label for a given IP block
object into the class.
Add new subroutine to Netdot::Model::Ipblock, dns_address_record_label
that returns 'A' or 'AAAA' depending on the version of the object.
Also add in some unit tests.