Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add USE_LAPACK as CMake option, with default true #257

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

nmusolino
Copy link
Contributor

@nmusolino nmusolino commented Oct 31, 2023

The scs Makefile recognizes the compile flag USE_LAPACK, which controls whether LAPACK is linked in. But when scs is used through CMake (with add_subdirectory("scs")), it unconditionally uses LAPACK; there is no way to set USE_LAPACK=0.

This MR adds USE_LAPACK as a CMake variable, alongside other CMake variables like like DLONG and USE_OPENMP. This should allow CMake-based projects to control the USE_LAPACK compile option. The default value is true, of course, for backward compatibility.

@nmusolino
Copy link
Contributor Author

FYI @bodono .

@bodono
Copy link
Member

bodono commented Oct 31, 2023

Thanks @nmusolino !

@bodono bodono merged commit 10dec35 into cvxgrp:master Oct 31, 2023
21 checks passed
@nmusolino nmusolino deleted the add-cmake-variable-USE_LAPACK branch May 1, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants