Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial commit for free agent auction report #59

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

initial commit for free agent auction report #59

wants to merge 1 commit into from

Conversation

harry19023
Copy link

@harry19023 harry19023 commented Oct 7, 2019

I wanted a function that would allow me to automatically post the Free Agent Auction report to Slack/GroupMe/etc/. I'm only in leagues that use FAAB. This could be generalized to include other waiver systems, but I would need an example public league to test on.

This is my first PR, so let me know if anything looks off!

@codecov-io
Copy link

Codecov Report

Merging #59 into master will decrease coverage by 12.06%.
The diff coverage is 8.6%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #59       +/-   ##
===========================================
- Coverage   91.37%   79.31%   -12.07%     
===========================================
  Files          12       13        +1     
  Lines         545      638       +93     
===========================================
+ Hits          498      506        +8     
- Misses         47      132       +85
Impacted Files Coverage Δ
ff_espn_api/free_agent_auction_bid.py 14.28% <14.28%> (ø)
ff_espn_api/league.py 73.33% <5.17%> (-12.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 660ef8b...14cfdd2. Read the comment docs.

@cwendt94
Copy link
Owner

cwendt94 commented Oct 9, 2019

Thanks for posting a PR! I will try to look at this fully later today.

One note, could you make a unit test for this new code.

Also I have never played in a FAAB league before but do you know if you can get this data through the recent_activity endpoint?

@harry19023
Copy link
Author

I'll work on those tests soon. And no you can't get the same info from recent activity, because in auction leagues you can see the failed bids. Because failed bids don't end up as an actual transaction they won't appear on the activity feed.

image

@cwendt94
Copy link
Owner

cwendt94 commented Oct 9, 2019

Very interesting! I will also try out that endpoint in my non FAAB league and see what else it returns.

@itstooerli
Copy link

I've actually been looking into including offers report into this module, and apparently everything I need has been here already!

I'm curious to know what needs to be worked on here to get this integrated/merged?

@cwendt94
Copy link
Owner

This PR was created before the package was refactored for multiple sports. This endpoint can be used for all league types to get wavier report.

I think we could do something similar to how baseball created different box_score categories depending on the league settings. So we could do the same for wavier report. Create a wavier report class and have it add different data depending on if the League is FABB or just normal wavier claims.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants