Skip to content

Commit

Permalink
Fix profiling with tracy. (gfx-rs#5988)
Browse files Browse the repository at this point in the history
The profiling APIs require a `&str`, but since the label here
is now an `Option<String>`, we must get a `&str` from it.

(cherry picked from commit 20973d1)

# Conflicts:
#	CHANGELOG.md
  • Loading branch information
waywardmonkeys authored and cwfitzgerald committed Jul 31, 2024
1 parent 908bab4 commit 0253a4f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ Bottom level categories:

#### General

- Fix profiling with `tracy`. By @waywardmonkeys in [#5988](https://github.com/gfx-rs/wgpu/pull/5988)
- Fix function for checking bind compatibility to error instead of panic. By @sagudev [#6012](https://github.com/gfx-rs/wgpu/pull/6012)
- Fix crash when dropping the surface after the device. By @wumpf in [#6052](https://github.com/gfx-rs/wgpu/pull/6052)
- Fix length of copy in `queue_write_texture`. By @teoxoy in [#6009](https://github.com/gfx-rs/wgpu/pull/6009)
Expand Down
2 changes: 1 addition & 1 deletion wgpu-core/src/command/render.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1566,7 +1566,7 @@ impl Global {

profiling::scope!(
"CommandEncoder::run_render_pass {}",
base.label.unwrap_or("")
base.label.as_deref().unwrap_or("")
);

let Some(cmd_buf) = pass.parent.as_ref() else {
Expand Down

0 comments on commit 0253a4f

Please sign in to comment.