Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 2.2.0 #64

Merged
merged 3 commits into from
Apr 30, 2020
Merged

Bump version to 2.2.0 #64

merged 3 commits into from
Apr 30, 2020

Conversation

izgeri
Copy link
Contributor

@izgeri izgeri commented Apr 30, 2020

This PR also:

  • Adds missing recent changes to the change log
  • Moves binaries to the bin/ directory
  • Updates the method used in test scripts to check whether Conjur / DAP is ready
  • Adds release instructions to CONTRIBUTING
  • Adds a NOTICES.txt file to the project

@izgeri izgeri self-assigned this Apr 30, 2020
Copy link
Contributor

@sgnn7 sgnn7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@izgeri Just one tiny nit

CHANGELOG.md Outdated
### Added
- Enabled supplying alternative authentication URLs when instantiating the client, which allows clients to use
alternative Conjur authentication methods such as authn-iam and authn-oidc. ([cyberark/conjur-api-java#40](https://github.com/cyberark/conjur-api-java/issues/40))
- Maven maven pom.xml file includes fat jar creation to allow easy incorporation of this client ([PR cyberark/conjur-api-java#47](https://github.com/cyberark/conjur-api-java/issues/47))
Copy link
Contributor

@sgnn7 sgnn7 Apr 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maven maven maven maven maven maven mushroom MUSHROOM!

@izgeri izgeri changed the title Update CHANGELOG.md Bump version to 2.2.0 Apr 30, 2020
Geri Jennings added 2 commits April 30, 2020 17:11
Also revises methods for waiting for healthy Conjur and DAP servers, using
native wait commands instead of a local bespoke tool
Copy link
Contributor

@sgnn7 sgnn7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@izgeri One tiny nit

CONTRIBUTING.md Outdated
updated, update the NOTICES.txt with those corresponding changes.
1. Review the [CHANGELOG.md](CHANGELOG.md) against the unreleased commits and
make sure all user-relevant changes have been captured.
1. Based on the unreleased content, determine the new version number and pdate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Based on the unreleased content, determine the new version number and pdate
1. Based on the unreleased content, determine the new version number and update

Also adds a NOTICES.txt to the project and updates the CONTRIBUTING guide to
include release instructions
@codeclimate
Copy link

codeclimate bot commented Apr 30, 2020

Code Climate has analyzed commit f1e8373 and detected 50 issues on this pull request.

Here's the issue category breakdown:

Category Count
Bug Risk 38
Style 12

View more on Code Climate.

Copy link
Contributor

@sgnn7 sgnn7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@izgeri LGTM - CC issues are deferred into their own issue

@sgnn7 sgnn7 merged commit a07dcdc into master Apr 30, 2020
@sgnn7 sgnn7 deleted the izgeri-patch-1 branch April 30, 2020 21:23
@izgeri
Copy link
Contributor Author

izgeri commented Apr 30, 2020

CC issue is #65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants