-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump version to 2.2.0 #64
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@izgeri Just one tiny nit
CHANGELOG.md
Outdated
### Added | ||
- Enabled supplying alternative authentication URLs when instantiating the client, which allows clients to use | ||
alternative Conjur authentication methods such as authn-iam and authn-oidc. ([cyberark/conjur-api-java#40](https://github.com/cyberark/conjur-api-java/issues/40)) | ||
- Maven maven pom.xml file includes fat jar creation to allow easy incorporation of this client ([PR cyberark/conjur-api-java#47](https://github.com/cyberark/conjur-api-java/issues/47)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maven maven maven maven maven maven mushroom MUSHROOM!
Also revises methods for waiting for healthy Conjur and DAP servers, using native wait commands instead of a local bespoke tool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@izgeri One tiny nit
CONTRIBUTING.md
Outdated
updated, update the NOTICES.txt with those corresponding changes. | ||
1. Review the [CHANGELOG.md](CHANGELOG.md) against the unreleased commits and | ||
make sure all user-relevant changes have been captured. | ||
1. Based on the unreleased content, determine the new version number and pdate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1. Based on the unreleased content, determine the new version number and pdate | |
1. Based on the unreleased content, determine the new version number and update |
Also adds a NOTICES.txt to the project and updates the CONTRIBUTING guide to include release instructions
Code Climate has analyzed commit f1e8373 and detected 50 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@izgeri LGTM - CC issues are deferred into their own issue
CC issue is #65 |
This PR also:
bin/
directory