Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unwanted certs removal #2954

Merged
merged 1 commit into from
Sep 15, 2023
Merged

fix unwanted certs removal #2954

merged 1 commit into from
Sep 15, 2023

Conversation

tarnowsc
Copy link
Contributor

@tarnowsc tarnowsc commented Sep 15, 2023

Desired Outcome

it seems that the the following PR never found it's way to the master:
https://github.com/cyberark/conjur/pull/2932/files

Implemented Changes

reapply fix for certificate removal

Connected Issue/Story

Resolves #[relevant GitHub issue(s), e.g. 76]

CyberArk internal issue ID: CNJR-2591

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@tarnowsc tarnowsc requested a review from a team as a code owner September 15, 2023 11:42
@codeclimate
Copy link

codeclimate bot commented Sep 15, 2023

Code Climate has analyzed commit 3eaf3b9 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 88.5% (0.0% change).

View more on Code Climate.

@tarnowsc tarnowsc merged commit 51cae50 into master Sep 15, 2023
2 of 4 checks passed
@tarnowsc tarnowsc deleted the remove_certs branch September 15, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants