Quote multi-line values in @SUMMONENVFILE

cyberark · Feb 5, 2021 · 39656f6 · 39656f6
1 parent cec67d2
commit 39656f6
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/internal/command/action.go b/internal/command/action.go
@@ -7,6 +7,7 @@ import (
 	"os/exec"
 	"path/filepath"
 	"sort"
+	"strconv"
 	"strings"
 	"sync"
 	"syscall"
@@ -199,9 +200,14 @@ func formatForEnv(key string, value string, spec secretsyml.SecretSpec, tempFact
 func joinEnv(env map[string]string) string {
 	var envs []string
 	for k, v := range env {
-		envs = append(envs, fmt.Sprintf("%s=%s", k, v))
+		if strings.Contains(v, "\n") {
+			keyEq := []byte(fmt.Sprintf("%s=", k))
+			envs = append(envs, string(strconv.AppendQuote(keyEq, v)))
+		} else {
+			envs = append(envs, fmt.Sprintf("%s=%s", k, v))
+		}
 	}
-	
+
 	// Sort to ensure predictable results
 	sort.Strings(envs)
 

diff --git a/internal/command/action_test.go b/internal/command/action_test.go
@@ -81,8 +81,8 @@ func TestFormatForEnvString(t *testing.T) {
 
 func TestJoinEnv(t *testing.T) {
 	Convey("adds a trailing newline", t, func() {
-		result := joinEnv(map[string]string{"foo": "bar", "baz": "qux"})
-		So(result, ShouldEqual, "baz=qux\nfoo=bar\n")
+		result := joinEnv(map[string]string{"foo": "bar\nfoo", "baz": "qux"})
+		So(result, ShouldEqual, "baz=qux\nfoo=\"bar\\nfoo\"\n")
 	})
 }