Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Support for @SUMMONVARNAMES #200

Closed
wants to merge 1 commit into from
Closed

Conversation

doodlesbykumbi
Copy link
Contributor

What does this PR do?

@SUMMONVARNAMES makes this possible, which avoids the multiline issues of @SUMMONENVFILE.

$ summon -p keyring.py -D env=dev env SUMMONVARNAMES=@SUMMONVARNAMES sh << EOL
docker run \$(printenv SUMMONVARNAMES | xargs printf -- '--env %s ' | xargs) deployer
EOL
  • What's changed? Why were these changes made?
  • How should the reviewer approach this PR, especially if manual tests are required?
  • Are there relevant screenshots you can add to the PR description?

What ticket does this PR close?

Resolves #199

Checklists

Change log

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or
  • This PR does not require updating any documentation

@doodlesbykumbi doodlesbykumbi requested a review from a team as a code owner February 2, 2021 14:18
@doodlesbykumbi doodlesbykumbi changed the title Support for @SUMMONVARNAMES WIP: Support for @SUMMONVARNAMES Feb 17, 2021
@ryanneufeld
Copy link

This would be fantastic to have

@ryanneufeld
Copy link

@jtuttle Any way this could be added?

@jtuttle
Copy link
Member

jtuttle commented Aug 5, 2021

@doodlesbykumbi Is this ready for review? I see it still says WIP.

@doodlesbykumbi
Copy link
Contributor Author

@jtuttle This PR was and to some extent still is really just experimental. We never got to a point where we found an approach that we were entirely happy with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Make list of environment variable names available in child process
4 participants