ci: relax hard-coded version check for git

[MikeMcC399]

Issue

CircleCI contains a check for a fixed version of git, however this version is not under control of the factory build process. This causes unplanned workflow failures when new versions of git are released.

This is the hard-coded check:

cypress-docker-images/circle.yml

Lines 132 to 141 in dc421e7

	- run:
	name: check git version
	command: |
	ACTUAL_VERSION=$(docker compose run test-factory-all-included git --version)
	if [ "git version 2.39.2" != "${ACTUAL_VERSION}" ]; then
	echo "Version mismatch, git package version: git version 2.39.2 != ${ACTUAL_VERSION}"
	exit 1;
	fi
	echo "Version ${ACTUAL_VERSION} confirmed"
	working_directory: factory/test-project

The version of git depends on the BASE_IMAGE:

cypress-docker-images/factory/.env

Line 9 in dc421e7

BASE_IMAGE='debian:12.7-slim'

and so far this is a Debian image, it depends also on the currently distributed package version according to Package git which is picked up by the build process:

cypress-docker-images/factory/factory.Dockerfile

Lines 33 to 34 in dc421e7

	&& apt-get update \
	&& apt-get install --no-install-recommends -y \

causing a refresh each time the cypress/factory image is rebuilt. This is what breaks the workflow job check-factory-versions from time to time.

Change

Remove the check for a specific version of git and report the version of git found.

This method is already used in the ssh check in the workflow lines of code following the git version check.

[cypress-app-bot]

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.

[MikeMcC399]

See https://app.circleci.com/pipelines/github/cypress-io/cypress-docker-images/2257/workflows/5e89adcb-aa45-428f-9cc0-ecf17d4ea550/jobs/69070/parallel-runs/0/steps/0-111

Version git version 2.39.5 confirmed

[jennifer-shehane]

We can relax the exact version match check, but we do need to exit the process if NO version of git exists to ensure we don’t release an image that does not have git installed, which happened before here: #874

Can you update the check to exit if a git version is not found at all?

[MikeMcC399]

@jennifer-shehane

We can relax the exact version match check, but we do need to exit the process if NO version of git exists to ensure we don’t release an image that does not have git installed, which happened before here: #874

Can you update the check to exit if a git version is not found at all?

• I tested in a dummy PR Test/check git version #1212 that the workflow fails if there is no git configured

The logic is the same as for ssh which follows in the workflow.