Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: correct ssh version output in circleci #1215

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

MikeMcC399
Copy link
Collaborator

Issue

The ssh version output in job check-factory-versions, step check ssh version in the circle.yml workflow is incorrectly formatted. See for instance https://app.circleci.com/pipelines/github/cypress-io/cypress-docker-images/2263/workflows/a3348dc7-4903-4dc9-807a-01b06f24fe90/jobs/69265/parallel-runs/0/steps/0-112

OpenSSH_9.2p1 Debian-2+deb12u3, OpenSSL 3.0.14 4 Jun 2024
Version  confirmed

In the command

ACTUAL_VERSION=$(docker compose run test-factory-all-included ssh -V)

the output of ssh -V is sent to stderr where it is output directly and not fed into the environment variable ACTUAL_VERSION.

Change

In the step check ssh version of the job check-factory-versions in the workflow circle.yml, redirect stderr to stdout with 2>&1 in the command:

ACTUAL_VERSION=$(docker compose run test-factory-all-included ssh -V 2>&1)

Verification

After the change, the ssh version output should be similar to:

Version OpenSSH_9.2p1 Debian-2+deb12u3, OpenSSL 3.0.14 4 Jun 2024 confirmed

Reference

Debian 1.5.8. Typical command sequences and shell redirection

@cypress-app-bot
Copy link

@MikeMcC399

This comment was marked as resolved.

@jennifer-shehane jennifer-shehane merged commit 2a12900 into cypress-io:master Sep 24, 2024
31 checks passed
@MikeMcC399 MikeMcC399 deleted the ssh-version-format branch September 24, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants