Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove S3 scanning #22

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Remove S3 scanning #22

merged 1 commit into from
Feb 15, 2024

Conversation

ccampo133
Copy link
Contributor

@ccampo133 ccampo133 commented Feb 14, 2024 •
edited
Loading

Description of the change

As title, per @nvemula-cyral's request. Also bump deps since there are a ton of dependabot PRs.

Type of change

  • Bug fix (non-breaking change that fixes an issue).
  • New feature (non-breaking change that adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklists

Development

  • Lint rules pass locally.
  • The code changed/added as part of this pull request has been covered with tests.
  • All tests related to the changed code pass.

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached.
  • Jira issue referenced in commit message and/or PR title.

Testing

Description of testing

@ccampo133 ccampo133 force-pushed the remove_s3 branch 2 times, most recently from ccf75be to 73b5c98 Compare February 14, 2024 21:07
yoursnerdly
yoursnerdly approved these changes Feb 14, 2024
View reviewed changes
Copy link

@yoursnerdly yoursnerdly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yoursnerdly yoursnerdly merged commit 3d6831d into main Feb 15, 2024
1 check passed
@yoursnerdly yoursnerdly deleted the remove_s3 branch February 15, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoursnerdly yoursnerdly yoursnerdly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ccampo133 @yoursnerdly