Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use map for scan results #23

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Use map for scan results #23

merged 1 commit into from
Feb 15, 2024

Conversation

ccampo133
Copy link
Contributor

@ccampo133 ccampo133 commented Feb 15, 2024

Description of the change

Use a map (keyed by ARN) for scan results instead of a slice. This ensures that duplicate scan results are avoided (e.g. if the same DynamoDB table is reported on multiple regional scans).

Type of change

  • Bug fix (non-breaking change that fixes an issue).
  • New feature (non-breaking change that adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklists

Development

  • Lint rules pass locally.
  • The code changed/added as part of this pull request has been covered with tests.
  • All tests related to the changed code pass.

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached.
  • Jira issue referenced in commit message and/or PR title.

Testing

Unit tests.

@ccampo133 ccampo133 requested review from VictorGFM, ricardorey10 and yoursnerdly and removed request for VictorGFM February 15, 2024 16:18
Copy link

@yoursnerdly yoursnerdly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ccampo133 ccampo133 merged commit a7f7882 into main Feb 15, 2024
1 check passed
@ccampo133 ccampo133 deleted the map_results branch February 15, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants