Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENG-13851: Use repo scan API #68

Merged
merged 4 commits into from
Apr 30, 2024
Merged

ENG-13851: Use repo scan API #68

merged 4 commits into from
Apr 30, 2024

Conversation

ccampo133
Copy link
Contributor

@ccampo133 ccampo133 commented Apr 24, 2024 •
edited
Loading

Description of the change

As title.

Type of change

  • Bug fix (non-breaking change that fixes an issue).
  • New feature (non-breaking change that adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklists

Development

  • Lint rules pass locally.
  • The code changed/added as part of this pull request has been covered with tests.
  • All tests related to the changed code pass.

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached.
  • Jira issue referenced in commit message and/or PR title.

Testing

Unit and manual tests.

VictorGFM
VictorGFM approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@VictorGFM VictorGFM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please consider my comment below before merging.

internal/api/api.go Outdated
dataLabelsPath = "/v1/datalabels"
classificationsPath = "/v1/repositories/{repoExternalID}/classifications"
classificationsPath = "/v1/classifications"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to prefix this with a /reposcans/{repoScanID}, based on the comments in the dmap-backend PR.

@ccampo133 ccampo133 merged commit a61b0ee into main Apr 30, 2024
3 checks passed
@ccampo133 ccampo133 deleted the ENG-13851 branch April 30, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VictorGFM VictorGFM VictorGFM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ccampo133 @VictorGFM