Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ServiceMonitor for scraping metrics using PrometheusOperator #7

Merged
merged 6 commits into from
Nov 14, 2024

Conversation

antoniomrfranco
Copy link
Collaborator

@antoniomrfranco antoniomrfranco commented Jul 26, 2024

Description of the change

Adding ServiceMonitor resource to make it easy to scrape metrics using Prometheus operator.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Jira issue referenced in commit message and/or PR title

Testing

  • Installed kube-prometheus-stack and deployed a new sidecar with metrics.enabled=true and metrics.serviceMonitor.enabled=true
  • Verified that Prometheus was pulling metrics from the sidecar:
    image

@antoniomrfranco antoniomrfranco marked this pull request as draft July 26, 2024 00:58
@antoniomrfranco antoniomrfranco marked this pull request as ready for review August 13, 2024 21:08
@antoniomrfranco antoniomrfranco changed the title Add ServiceMonitor resource for scraping metrics using PrometheusOperator Add ServiceMonitorfor scraping metrics using PrometheusOperator Aug 13, 2024
@antoniomrfranco antoniomrfranco changed the title Add ServiceMonitorfor scraping metrics using PrometheusOperator Add ServiceMonitor for scraping metrics using PrometheusOperator Aug 13, 2024
Copy link
Contributor

@wcmjunior wcmjunior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep docs in alphabetical order to make it easier to read.

README.md Outdated Show resolved Hide resolved
@wcmjunior wcmjunior removed the request for review from ptcar2009 November 14, 2024 18:02
@wcmjunior wcmjunior merged commit 0efaa85 into main Nov 14, 2024
@wcmjunior wcmjunior deleted the add-service-monitor branch November 14, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants