Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sort comments in explorer by selected location #124

Conversation

croesnick
Copy link
Contributor

Solves GH-121

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

See GH-121

What is the new behavior?

Sorts comments in the comment explorer ascending by location information.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@croesnick
Copy link
Contributor Author

croesnick commented Nov 26, 2021

Ouch. This could have been a bit easier if I would have seen #38 before 🙈
My changes so only bring this feature to the comment explorer. My underlying believe, however, still holds true: the necessity to split the CSV model from the internal data model (cf. #123).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants