Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Support] If the header or footer is absent, a guide assertion failure occurs. #39

Merged

Conversation

GeekTree0101
Copy link
Contributor

@GeekTree0101 GeekTree0101 commented Apr 30, 2024

배경

API declaration order is important when configuring header and footer, but there is a possibility of human error.

    .willDisplayHeader {
      ...
    }
    .withHeader(
      Some()
    )

    .withHeader(
      Some()
    )
    .willDisplayHeader {
      ...
    }
  • So, If the header or footer is absent, a guide assertion failure occurs.

수정 내역

  • support footer & header configuration guide assertion failrue

테스트 방법

  • no test

리뷰 노트

  • nope

@GeekTree0101 GeekTree0101 self-assigned this Apr 30, 2024
@GeekTree0101 GeekTree0101 added Bug Something isn't working Improvement and removed Bug Something isn't working labels Apr 30, 2024
Copy link
Member

@OhKanghoon OhKanghoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@GeekTree0101 GeekTree0101 merged commit 48f7991 into daangn:main Apr 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants