feat: add option to disable transition in solid integration

daangn · Oct 11, 2024 · 6802e68 · 6802e68
1 parent afe944b
commit 6802e68
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 4 deletions.
diff --git a/integrations/solid/src/__internal__/core/CoreProvider.tsx b/integrations/solid/src/__internal__/core/CoreProvider.tsx
@@ -13,16 +13,18 @@ export const CoreStateContext = createContext<{
 
 export interface CoreProviderProps {
   coreStore: CoreStore;
+  transition: boolean;
   children: JSXElement;
 }
 export const CoreProvider: Component<CoreProviderProps> = (props) => {
   const [stack, setStack] = createStore(props.coreStore.actions.getStack());
   const [pending, startTransition] = useTransition();
 
   props.coreStore.subscribe(() => {
-    startTransition(() => {
+    const update = () =>
       setStack(reconcile(props.coreStore.actions.getStack(), { merge: true }));
-    });
+    if (props.transition) startTransition(update);
+    else update();
   });
 
   return (

diff --git a/integrations/solid/src/future/StackComponentType.ts b/integrations/solid/src/future/StackComponentType.ts
@@ -3,4 +3,5 @@ import type { Component } from "solid-js";
 export type StackComponentType = Component<{
   initialContext?: any;
   initialLoaderData?: any;
+  transition?: boolean;
 }>;
diff --git a/integrations/solid/src/future/stackflow.tsx b/integrations/solid/src/future/stackflow.tsx
@@ -149,7 +149,10 @@ export function stackflow<
     return (
       <ConfigProvider value={input.config}>
         <PluginsProvider value={coreStore.pluginInstances}>
-          <CoreProvider coreStore={coreStore}>
+          <CoreProvider
+            coreStore={coreStore}
+            transition={props.transition ?? true}
+          >
             <MainRenderer
               activityComponentMap={input.components}
               initialContext={initialContext()}

diff --git a/integrations/solid/src/stable/stackflow.tsx b/integrations/solid/src/stable/stackflow.tsx
@@ -25,6 +25,7 @@ import { useStepActions } from "./useStepActions";
 
 export type StackComponentType = Component<{
   initialContext?: any;
+  transition?: boolean;
 }>;
 
 type StackflowPluginsEntry<T extends BaseActivities> =
@@ -197,7 +198,10 @@ export function stackflow<T extends BaseActivities>(
 
     return (
       <PluginsProvider value={coreStore.pluginInstances}>
-        <CoreProvider coreStore={coreStore}>
+        <CoreProvider
+          coreStore={coreStore}
+          transition={props.transition ?? true}
+        >
           <MainRenderer
             activityComponentMap={activityComponentMap}
             initialContext={props.initialContext}