Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn against deeply nested let exprs (WIP) #5588

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Warn against deeply nested let exprs (WIP) #5588

wants to merge 4 commits into from

Commits on Jun 28, 2024

  1. Replace bool inLetExprBody with int letExprNesting

    @robin-aws
    robin-aws committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    e7310fd View commit details
    Browse the repository at this point in the history

  2. Replace (letExprNesting: )false with 0

    @robin-aws
    robin-aws committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    aad83ff View commit details
    Browse the repository at this point in the history

  3. Replace (letExprNesting: )true with letExprNesting + 1 

    And the one actual read of the parameter :)
    @robin-aws
    robin-aws committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    0b586b6 View commit details
    Browse the repository at this point in the history

  4. Emit warning

    @robin-aws
    robin-aws committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    7857ea3 View commit details
    Browse the repository at this point in the history