fix: Partially fix nightly build for 4.2 #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suspected as the reason nightly build looks green when it actually isn’t
robin-aws
changed the title
atomb
previously approved these changes
Jul 11, 2023
…yway)" This reverts commit 09223c5.
When I cut this PR I thought I was just making progress on working against the latest nightly, but now I see that 4.1 has never worked. :( I'll merge this by temporarily changing the branch protection rules, just because I think turning the nightly build red as it should be is important for visibility as well. |
atomb
approved these changes
Jul 11, 2023
|
I've re-added 4.1 as a required check, so the CI is effectively broken on this repo now as intended. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only fixes the fact that the top-level workflow looks green even though the job fails (https://github.com/dafny-lang/libraries/actions/runs/5506948866) and adds
--compile-suffixwhen necessary.By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.