[graphql] refactor node def, config, and type resolution from assets #25552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @alangenfeld and the rest of your teammates on |
alangenfeld
force-pushed
the
al/cached_nodes
branch
2 times, most recently
from
4364545
to
592d0df
Compare
alangenfeld
force-pushed
the
al/cached_nodes
branch
from
592d0df
to
db49e7a
Compare
gibsondan
approved these changes
Oct 25, 2024
| @@ -391,36 +391,42 @@ def stale_status_loader(self) -> StaleStatusLoader: | |||
| def asset_graph_differ(self) -> Optional[AssetGraphDiffer]: | |||
| return self._asset_graph_differ | |||
|
|
|||
| def _job_selector(self) -> Optional[JobSelector]: | |||
| if len(self._asset_node_snap.job_names) < 1: | |||
| @@ -19,28 +19,26 @@ | |||
|
|
|||
|
|
|||
| def to_config_type( | |||
| config_schema_snapshot: ConfigSchemaSnapshot, config_type_key: str | |||
| get_config_type: Callable[[str], ConfigTypeSnap], | |||
There was a problem hiding this comment.
maybe worth a comment about why this is deferred?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go through the context for resolving pieces of information to facilitate different backing implementations in other workspace classes.
How I Tested These Changes
existing tests