[pipes] add PipesLogWriter #25564
Open
[pipes] add PipesLogWriter #25564
+263
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @danielgafni and the rest of your teammates on |
|
Behold! An in-progress PR for the The solution relies on @smackesey @schrockn I'd like to get some initial comments on the overall design of the new component (not looking for a detailed review yet, also don't mind initialization logic - it's incomplete) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Adding a new
PipesLogWriterPipes component.It allows capturing and saving
stdout/stderrlogs to a known location.This is meant to be an escape hatch for execution environments which don't have a clean way of accessing logs.
How I Tested These Changes
Added a test. Will be adding more.
Changelog
Added a new Dagster Pipes component -
PipesLogWriter.