Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Force user to go through onboarding steps for every registration #4014

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

AmarTrebinjac
Copy link
Contributor

@AmarTrebinjac AmarTrebinjac commented Dec 22, 2024

Changes

This should prevent the user from refreshing to skip the necessary steps.

The user can still remove the /onboarding path and they will still be able to skip it. Unsure if we want to prevent this or not. Should be possible, but would require more checks that go beyond the onboarding page. However, they will still be prompted to complete next time they login. This will also affect currently existing users, as they will not have the two new actions completed already. Not sure if we want this, or if we would like to run a script to check these tasks for already existing users.

Events

Did you introduce any new tracking events?

Experiment

Did you introduce any new experiments?

Manual Testing

Caution

Please make sure existing components are not breaking/affected by this PR

MI-700 #done

Preview domain

https://mi-700.preview.app.daily.dev

Copy link

vercel bot commented Dec 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
daily-webapp ✅ Ready (Inspect) Visit Preview Dec 22, 2024 5:34pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
storybook ⬜️ Ignored (Inspect) Dec 22, 2024 5:34pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant