Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate the HKDF classes dependent on external modules from the independent base class. #212

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

dajiaji
Copy link
Owner

@dajiaji dajiaji commented Jul 28, 2023

No description provided.

@dajiaji dajiaji force-pushed the separate-hkdf branch 2 times, most recently from b9d5399 to e650afc Compare July 28, 2023 07:51
@codecov-commenter
Copy link

Codecov Report

Merging #212 (e650afc) into main (b0c9aaf) will decrease coverage by 0.78%.
The diff coverage is 98.90%.

@@            Coverage Diff             @@
##             main     #212      +/-   ##
==========================================
- Coverage   96.90%   96.13%   -0.78%     
==========================================
  Files          26       29       +3     
  Lines        2427     2485      +58     
  Branches      216      217       +1     
==========================================
+ Hits         2352     2389      +37     
- Misses         75       96      +21     
Flag Coverage Δ
unittests 96.13% <98.90%> (-0.78%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/kdfs/hkdf.ts 86.22% <80.00%> (-12.72%) ⬇️
src/cipherSuite.ts 100.00% <100.00%> (ø)
src/kdfs/hkdfSha256.ts 100.00% <100.00%> (ø)
src/kdfs/hkdfSha384.ts 100.00% <100.00%> (ø)
src/kdfs/hkdfSha512.ts 100.00% <100.00%> (ø)
src/kems/dhkemP256.ts 100.00% <100.00%> (ø)
src/kems/dhkemP384.ts 100.00% <100.00%> (ø)
src/kems/dhkemP521.ts 100.00% <100.00%> (ø)
src/kems/dhkemX25519.ts 100.00% <100.00%> (ø)
src/kems/dhkemX448.ts 100.00% <100.00%> (ø)

@dajiaji dajiaji merged commit 8775178 into main Jul 28, 2023
15 checks passed
@dajiaji dajiaji deleted the separate-hkdf branch August 13, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants