Increase the input limits from 128 bytes to 8192 bytes #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, the 128 byte limit is problematic for `info` as used in the Mobile Document Request API (https://github.com/WICG/mobile-document-request-api) and similar schemes.
Codecov Report
@@ Coverage Diff @@
## main #222 +/- ##
=======================================
Coverage 97.01% 97.01%
=======================================
Files 32 32
Lines 2483 2483
Branches 224 224
=======================================
Hits 2409 2409
Misses 73 73
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Thanks for the PR. In JavaScript, basically, there is no need to impose restrictions on the size of "info", but I applied quite strict constraints as the initial implementation. There is no problem with relaxing it to 8192 bytes. |
|
@snorp As a supplementary note, I have plans to release v1.0.0 within the next few days. The next release after merging this PR will be v1.0.0, and please be aware that it contains some BREAKING changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, the 128 byte limit is problematic for
infoas used inthe Mobile Document Request API (https://github.com/WICG/mobile-document-request-api)
and similar schemes.