{curve,ed}25519-dalek: clippy fixes #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clippy 1.81 brings new lints, this fixes those warnings
tarcieri
reviewed
Sep 30, 2024
| @@ -240,7 +240,9 @@ impl u64x4 { | |||
| pub const fn new_const(x0: u64, x1: u64, x2: u64, x3: u64) -> Self { | |||
| // SAFETY: Transmuting between an array and a SIMD type is safe | |||
| // https://rust-lang.github.io/unsafe-code-guidelines/layout/packed-simd-vectors.html | |||
| unsafe { Self(core::mem::transmute([x0, x1, x2, x3])) } | |||
| unsafe { | |||
| Self(core::mem::transmute::<[u64; 4], core::arch::x86_64::__m256i>([x0, x1, x2, x3])) | |||
There was a problem hiding this comment.
Will merge this as-is to prevent conflicts on your other branch, but core::arch::x86_64::__m256i is probably worth importing so you can just call this __m256i (here and below)
There was a problem hiding this comment.
Yeah, the only reason I went with the full name was because it was already used that way higher up in the script. I'm not familiar enough with simd to know whether _m256i exists elsewhere (in which case the full name might be intended)
tarcieri
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clippy 1.81 brings new lints, this fixes those warnings