Improve basic_json ctors

danielaparker · Oct 21, 2024 · c4e3f78 · c4e3f78
1 parent 26418fe
commit c4e3f78
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/include/jsoncons/basic_json.hpp b/include/jsoncons/basic_json.hpp
@@ -3244,7 +3244,7 @@ namespace jsoncons {
         }
 
         template <typename IntegerType>
-        basic_json(IntegerType val, semantic_tag tag, 
+        basic_json(IntegerType val, semantic_tag tag = semantic_tag::none, 
                    typename std::enable_if<extension_traits::is_unsigned_integer<IntegerType>::value && sizeof(IntegerType) <= sizeof(uint64_t), int>::type = 0)
         {
             construct<uint64_storage>(val, tag);
@@ -3313,7 +3313,7 @@ namespace jsoncons {
             construct<null_storage>(tag);
         }
 
-        basic_json(bool val, semantic_tag tag)
+        basic_json(bool val, semantic_tag tag = semantic_tag::none)
         {
             construct<bool_storage>(val,tag);
         }

diff --git a/test/corelib/src/ojson_object_tests.cpp b/test/corelib/src/ojson_object_tests.cpp
@@ -93,6 +93,7 @@ TEST_CASE("ojson object erase with iterator")
         CHECK(doc.size() == 1);
         CHECK(doc.at("b") == 2);
         CHECK(doc.at("b") == 2.0);
+        CHECK(doc.at("b") == 2.0f);
         CHECK(doc["b"] == 2);
     }