-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing pickle methods #535
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cetanu
force-pushed
the
vsyrakis/add-pickle-methods
branch
2 times, most recently
from
October 13, 2023 08:49
b34bd2b
to
3fe5c50
Compare
Gobot1234
reviewed
Oct 13, 2023
Working on a more complicated test, which is now raising a question for me |
cetanu
commented
Oct 13, 2023
cetanu
force-pushed
the
vsyrakis/add-pickle-methods
branch
from
October 13, 2023 12:58
4edd152
to
0b0345f
Compare
cetanu
force-pushed
the
vsyrakis/add-pickle-methods
branch
2 times, most recently
from
October 16, 2023 11:04
d256ec1
to
abe3fdb
Compare
cetanu
force-pushed
the
vsyrakis/add-pickle-methods
branch
from
October 16, 2023 11:06
abe3fdb
to
06e94c9
Compare
cetanu
force-pushed
the
vsyrakis/add-pickle-methods
branch
from
October 16, 2023 11:08
06e94c9
to
fa25d17
Compare
Gobot1234
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing work from #484 by @kevinaud to fix #419