Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing pickle methods #535

Merged
merged 6 commits into from
Oct 16, 2023
Merged

Implementing pickle methods #535

merged 6 commits into from
Oct 16, 2023

Conversation

cetanu
Copy link
Collaborator

@cetanu cetanu commented Oct 13, 2023

Continuing work from #484 by @kevinaud to fix #419

@cetanu cetanu force-pushed the vsyrakis/add-pickle-methods branch 2 times, most recently from b34bd2b to 3fe5c50 Compare October 13, 2023 08:49
@cetanu cetanu marked this pull request as draft October 13, 2023 09:29
@cetanu cetanu marked this pull request as ready for review October 13, 2023 09:47
@cetanu cetanu requested a review from Gobot1234 October 13, 2023 09:48
@cetanu cetanu self-assigned this Oct 13, 2023
@cetanu cetanu added the enhancement New feature or request label Oct 13, 2023
src/betterproto/__init__.py Outdated Show resolved Hide resolved
src/betterproto/__init__.py Show resolved Hide resolved
@cetanu
Copy link
Collaborator Author

cetanu commented Oct 13, 2023

Working on a more complicated test, which is now raising a question for me

@cetanu cetanu marked this pull request as draft October 13, 2023 12:38
@cetanu cetanu force-pushed the vsyrakis/add-pickle-methods branch from 4edd152 to 0b0345f Compare October 13, 2023 12:58
@cetanu cetanu marked this pull request as ready for review October 13, 2023 12:59
@cetanu cetanu requested a review from nat-n October 15, 2023 08:01
@cetanu cetanu force-pushed the vsyrakis/add-pickle-methods branch 2 times, most recently from d256ec1 to abe3fdb Compare October 16, 2023 11:04
@cetanu cetanu force-pushed the vsyrakis/add-pickle-methods branch from abe3fdb to 06e94c9 Compare October 16, 2023 11:06
@cetanu cetanu force-pushed the vsyrakis/add-pickle-methods branch from 06e94c9 to fa25d17 Compare October 16, 2023 11:08
Copy link
Collaborator

@Gobot1234 Gobot1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cetanu cetanu merged commit ca6b9fe into master Oct 16, 2023
17 checks passed
@cetanu cetanu deleted the vsyrakis/add-pickle-methods branch October 16, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pickling a Betterproto message
2 participants