CI Improvements #54
Merged
CI Improvements #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the job would only run when opening or updating a PR. This was unintentional, and a result of a misunderstanding of the `$default-branch` “macro”, which is only used in workflow _templates_. In actual workflows, it does nothing. This just changes to explicitly using the branch name `main`. It’s important that the job run after merge in order to update the cache. The cache that’s saved when the PR is opened or updated is [isolated to just that PR][isolation], whereas the cache on `main` can be accessed by future PRs. [isolation]: https://docs.github.com/en/actions/using-workflows/caching-dependencies-to-speed-up-workflows#restrictions-for-accessing-a-cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checks: fix workflow to run after merging a PR
Previously the job would only run when opening or updating a PR. This
was unintentional, and a result of a misunderstanding of the
$default-branch“macro”, which is only used in workflow templates.In actual workflows, it does nothing. This just changes to explicitly
using the branch name
main.It’s important that the job run after merge in order to update the
cache. The cache that’s saved when the PR is opened or updated is
isolated to just that PR, whereas the cache on
maincanbe accessed by future PRs.
PR Checks:
cargo build --tests --all-features.PR Checks: add caching for
cargo msrv verify.