Allow choice of rounding behavior for ties #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielparks
force-pushed
the
tie-behavior
branch
2 times, most recently
from
bfa4621
to
5b16b13
Compare
danielparks
changed the title
danielparks
force-pushed
the
tie-behavior
branch
3 times, most recently
from
9d77c1b
to
cebd5d4
Compare
Traditionally, rounding a value that is exactly halfway between to round
values results in the higher round value:
10 == 5.round_to(10, Tie::Up)
This adds a parameter and `enum` to allow other rules for dealing with
“ties” — values that are halfway between two round numbers. The rule
mentioned above is represented by `Tie::Up` — ties choose the higher
number. The complete list of options is:
* `Tie::Up`
* `Tie::Down`
* `Tie::TowardZero`
* `Tie::AwayFromZero`
* `Tie::TowardEven`
* `Tie::TowardOdd`
Fixes #3 — Support other types of rounding.
danielparks
force-pushed
the
tie-behavior
branch
from
cebd5d4
to
a824504
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Traditionally, rounding a value that is exactly halfway between to round values results in the higher round value:
This adds a parameter and
enumto allow other rules for dealing with “ties” — values that are halfway between two round numbers. The rule mentioned above is represented byTie::Up— ties choose the higher number. The complete list of options is:Tie::UpTie::DownTie::TowardZeroTie::AwayFromZeroTie::TowardEvenTie::TowardOddFixes #3 — Support other types of rounding.
To do