-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔒 fix: update refresh token handling to use plain token instead of hashed token #5088
Conversation
@berry-13 I am experiencing issue with the previous and this fix, getting unlogined each time I refresh the page after logging in. |
what login strategy are you using? |
Email accounts. |
would you mind if we move this chat to a GitHub discussion or a Discord #issue? It'll help me understand better why it's not working for you |
sure, I'll create a discord issue in a moment |
@berry-13 if this is creating issues, you should revert your earlier fix. All we needed were sessions to be deleted on password reset |
This PR seems to fix the issue with sessions on SSL deployments, unsure about the local ones. We're currently investigating this further on discord issues channel. |
I've also found I'm unable to authenticate when using Authentik with OAuth2/OIDC, for now I'm back on the librechat:v0.7.6 image. |
@stanvx Not having issues with OIDC, you are likely using an image that includes the bug |
@danny-avila Thanks, I'll do some testing, check the logs, find out which image it started on and make an issue if needed. |
Okay, I confirmed on my side of things that I was using the image with the bug, for whatever reason the |
Summary
fix login bug caused by #5077
Change Type
Testing
Tested login, logout, api operations (like fetch convo and other basic interactions), refresh token logic, reset password
Checklist