Change the Join common\space flow

[elatif2020]

Currently if a user try to open a link for a common\space\stream she isn't part of she is redirected to the backpage of the relevant page, from which she can join.
We want to change it, in the case that
(1) For a space\ stream in a space: The admittance to the space is automatic (as defined in the relevant assign circle proposal's parameters), and the user is a member of the relevant root-common.
(2) For a (root) common\ stream in a common: The admittance to the common is automatic.

We will show the relevant feed item if it has public visibility setting, with join button instead of the inputBox as in the design here

If the relevant item is a space\common we should show similarly the Home feed item for this space\common.

• Add chat module design for the public view (user can see the chat, and with join button instead of the input box)

• Enable public view of the feed (show only items with public visibility)

• Disable redirection to the back page (if there is at least one public item) (if it is a space, only for parent-common members)

• If space admittance is automatic : skip the "join space" popup (only for space, not common) #1951

• TBD ? Change default proposal visibility according to the default of the common ?

[roienatan]

@elatif2020 regarding the 3rd point: "Disable redirection to the back page (if there is at least one public item) (if it is a space, only for parent-common members)." We always have the Home card which is public. I think we should completely disable the auto redirection. Let me know what you think please.

[elatif2020]

@elatif2020 regarding the 3rd point: "Disable redirection to the back page (if there is at least one public item) (if it is a space, only for parent-common members)." We always have the Home card which is public. I think we should completely disable the auto redirection. Let me know what you think please.

not exactly, the Home could be be not public

[roienatan]

For the current progress and what is left to be done see my comment in the PR.

[andreymikhadyuk]

@elatif2020 I just realised that we should have info whether the common has public feed items or not in the common model or somewhere else. Because we cannot check all the feed items to decide whether redirect user or not.

[andreymikhadyuk]

@elatif2020 we cannot allow guests to see feed at the moment, because BE does not allow to fetch the feed items and pinned ones when user is not authenticated.

[elatif2020]

@elatif2020 I just realised that we should have info whether the common has public feed items or not in the common model or somewhere else. Because we cannot check all the feed items to decide whether redirect user or not.

Created a BE issue for this
https://github.com/daostack/common-backend/issues/2049

[elatif2020]

• Change the Join button text to just "Join" (both for a space and for a common)
• Disable showing the front page for a space for which the user isn't a member of the parent common.
  Show the space backpage in this case.

[budnik9]

@elatif2020 What is front page and backpage for a space? Could you please provide me examples?

[elatif2020]

@elatif2020 What is front page and backpage for a space? Could you please provide me examples?

@budnik9
Sure, sorry it wasn't clear.

This is the frontpage:

And this is the backpage:

[budnik9]

@elatif2020 Should we check if the user is a member only of the direct parent common or all parent commons to show backpage / frontpage for a user?
For example, we have this structure:

L1 common
    L2 space
        L3 space
            L4 space

For L4 space should we check only L3 space or all ancestors (L3, L2, L1)? Because now I can leave (for example) L2 space without leaving L3 and L4 spaces. Maybe this is a bug.

[elatif2020]

@elatif2020 Should we check if the user is a member only of the direct parent common or all parent commons to show backpage / frontpage for a user?
For example, we have this structure:

L1 common
    L2 space
        L3 space
            L4 space

For L4 space should we check only L3 space or all ancestors (L3, L2, L1)? Because now I can leave (for example) L2 space without leaving L3 and L4 spaces. Maybe this is a bug.

@budnik9
only direct parent