Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the Join common\space flow #1940 #1964

Merged
merged 16 commits into from
Sep 3, 2023

Conversation

roienatan
Copy link
Collaborator

@roienatan roienatan commented Aug 14, 2023

  • PR title equals to the ticket name
  • I added the ticket to the Development section of this PR.

What was changed?

  • New join common/space flow. See ticket for more details.

@netlify
Copy link

netlify bot commented Aug 14, 2023

Deploy Preview for preview-common ready!

Name Link
🔨 Latest commit 9c91be2
🔍 Latest deploy log https://app.netlify.com/sites/preview-common/deploys/64e4a043ee51870008c8d962
😎 Deploy Preview https://deploy-preview-1964--preview-common.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@roienatan roienatan linked an issue Aug 14, 2023 that may be closed by this pull request
5 tasks
@roienatan
Copy link
Collaborator Author

Updating regarding the current progress and what is left to be done.
Currently the redirection is disabled. For a non-member it's possible to see all the public items and it's possible to join a space/common from the chat component.

Missing functionality:

  • Disable redirection only if there is at least one public item in common/space.
  • Disable redirection only if the common is auto admission.
  • For a space, disable redirection only if the user is a member in the parent common.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the Join common\space flow
3 participants